Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuda array interface #43

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

SimonRit
Copy link
Collaborator

Adding export code to #42

LucasGandel and others added 9 commits August 9, 2024 17:21
Prior to this commit CudaDataManager::GetGPUBufferPointer() returned a
pointer to the GPU buffer pointer. Its return type should have been void**.
Every usage of this method across RTK and CudaCommon dereference the
returned pointer pointer, so just return the buffer pointer directly as it
required for future commits adding support for __cuda_array_interface__
Adapt ITK's PyBuffer approach to inject __cuda_array_interface__ in wrapped
code.
Closes RTKConsortium#10
This allows modules like RTK to easily reuse files from the CudaCommon
sources, e.g. CudaImage.i.init and CudaImage.i.in
@SimonRit SimonRit force-pushed the cuda-array-interface branch from 9e356cf to e176586 Compare December 19, 2024 17:47
CMakeLists.txt Outdated Show resolved Hide resolved
@LucasGandel LucasGandel mentioned this pull request Dec 20, 2024
6 tasks
@SimonRit
Copy link
Collaborator Author

This is a detail but fc4cfa8 and 792d00e could be squashed into a single commit. This PR will be merged for CudaCommon v2, after a first release of CudaCommon v1.2, based on ITK v5.4.1 and/or v5.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants